ced4568andClaude Sonnet 5
de03dbde9a
Root cause, confirmed empirically (not guessed): 1. node-gyp generates an incorrect build/config.gypi for this NodeSource-packaged Node 20 build — it reports node_shared: true (expects a shared libnode.so), but the actual installed Node is statically linked (no libnode.so.<abi> exists anywhere on the system; process.config.variables.node_shared on the real running Node is false). node-gyp trusted the wrong config and linked node-pty's native addon against -lnode, producing a binary that fails at require() time with "libnode.so.127: cannot open shared object file" — confirmed by loading the compiled .node file directly, bypassing node-pty's own path-search/error-masking logic (which collapses this into a generic "Cannot find module .../pty.node" across every path it checks). 2. A second, independent bug compounded it: no .dockerignore existed. A host-side `npm install` (run earlier for backend testing) left backend/node_modules on disk, built against the host's own environment. The Dockerfile's `COPY backend/ ./backend/` (placed after the npm-install RUN layer, for build-cache efficiency) silently overwrote the correctly-built node_modules with that host copy — including after a first .dockerignore fix using the pattern `node_modules/`, which only matches a node_modules directory at the build context ROOT in Docker's matching rules, not at any depth (unlike .gitignore, where the same-looking pattern does match any depth — a real, confirmed gotcha, not an assumption). Fix: - Dockerfile: `ENV npm_config_node_shared=false` (image-level, not a one-off RUN prefix, so it can't be silently lost if a native module ever gets rebuilt again for any reason) + a build-time `node -e "require(...)"` check that fails the build loudly if this regresses, instead of shipping a silent runtime failure. - .dockerignore: `**/node_modules/` (recursive), not `node_modules/`. No terminal architecture change, no fake shell, no changes to backend/server.js's PTY handling. RootNode branding and upstream KubeKosh attribution untouched. The single-container dev workflow (`docker build -t rootnode-academy:test .`) is the same command as before — it now just works. Verified against the real image end-to-end, not a stand-in: build -> container starts -> k3s reaches Ready -> backend starts, no crash -> nginx starts -> browser UI 200s -> terminal WebSocket opens showing the RootNode banner -> `kubectl get nodes` run through the terminal returns real cluster state -> deploy-nginx scenario solved via the terminal -> all 5 validation checks pass. Co-Authored-By: Claude Sonnet 5 <[email protected]>
18 lines
1.0 KiB
Plaintext
18 lines
1.0 KiB
Plaintext
# Root cause of the node-pty "Cannot find module .../pty.node" failure (Phase 2A): with no
|
|
# .dockerignore, a host-side `npm install` (e.g. for local testing) leaves backend/node_modules
|
|
# on disk, built against the host's own Node/libnode — not the container's. The Dockerfile's
|
|
# later `COPY backend/ ./backend/` (done after the npm-install RUN layer, for build caching)
|
|
# then silently overwrites the correctly-built-in-container node_modules with that host copy,
|
|
# which fails to load at runtime with an ABI/architecture mismatch. Native modules (node-pty,
|
|
# better-sqlite3) MUST always be built inside the image, never leaked in from the host.
|
|
#
|
|
# IMPORTANT: bare `node_modules/` only matches a node_modules directory at the build context
|
|
# ROOT in Docker's .dockerignore matching rules — it does NOT recursively match
|
|
# backend/node_modules or frontend/node_modules. This bit us once already (fixed here with
|
|
# `**/`): a first pass at this file used the bare pattern and the leak still happened.
|
|
**/node_modules/
|
|
frontend/dist/
|
|
.git/
|
|
*.db
|
|
*.db-journal
|